This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH v3 1/2] gdb: Add process record and replay support for s390.
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Cc: gdb-patches at sourceware dot org, koriakin at 0x04 dot net (Marcin KoÅcielnicki)
- Date: Tue, 3 Nov 2015 15:17:04 +0100 (CET)
- Subject: Re: [PATCH v3 1/2] gdb: Add process record and replay support for s390.
- Authentication-results: sourceware.org; auth=none
Marcin KoÃ?cielnicki <koriakin at 0x04 dot net> wrote:
> * gdb/configure.tgt: Add linux-record.o to s390*-linux.
> * gdb/s390-linux-tdep.c: #include "linux-record.h", "record-full.h"
> (s390_linux_record_tdep): New static global variable.
> (s390x_linux_record_tdep): New static global variable.
> (s390_all_but_pc_registers_record): New function.
> (s390_canonicalize_syscall): New function.
> (s390_linux_syscall_record): New function.
> (s390_linux_record_signal): New function.
> (s390_record_calc_disp_common): New function.
> (s390_record_calc_disp): New function.
> (s390_record_calc_disp_vsce): New function.
> (s390_record_calc_rl): New function.
> (s390_record_gpr_g): New function.
> (s390_record_gpr_h): New function.
> (s390_record_vr): New function.
> (s390_process_record): New function.
> (s390_init_linux_record_tdep): New function.
> (s390_gdbarch_init): Fill record function slots.
> * gdb.reverse/s390-mvcle.c: New test.
> * gdb.reverse/s390-mvcle.exp: New file.
> * lib/gdb.exp: Enable reverse tests on s390*-linux.
> First patch fixed according to comments from review. LCBB also moved to
> 32-bit destination section. I'm still working on the second patch, and will
> resubmit it later.
> I haven't changed size_msqid_ds and size_shmid_ds - the target-independent
> code for recording ipc operations is horribly broken, and doesn't distinguish
> between calls that should use msqid_ds and msqid64_ds (or msginfo, for that
> matter), using size_msqid_ds either way (same for shm). Since modern glibc
> uses msqid64_ds, this is the less wrong size to use. I'll cook up a proper
> fix for the IPC problem soon on all supported targets, for now let's leave
> it as msqid64_ds size.
Ah, I see. Well, saving a slightly too large size in some cases doesn't
really matter all that much, so I'm fine with this.
The patch is OK.
Thanks again for working on this!
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain