This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFC][PATCH 04/15] Fix crash in tstatus after detach
- From: "Wallin, Henrik" <Henrik dot Wallin at windriver dot com>
- To: Gary Benson <gbenson at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 29 Oct 2015 17:50:18 +0000
- Subject: RE: [RFC][PATCH 04/15] Fix crash in tstatus after detach
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1444820235 dot git dot henrik dot wallin at windriver dot com> <410dda80c8530a193308630ff74a456fadd4bc9e dot 1444820235 dot git dot henrik dot wallin at windriver dot com>,<20151014114807 dot GA30077 at blade dot nx>
2015-10-14 13:48 GMT+02:00 Gary Benson <gbenson@redhat.com>:
> Hi Henrik,
>
> henrik.wallin@windriver.com wrote:
>> diff --git a/gdb/common/agent.c b/gdb/common/agent.c
>> index 5c307290589d..c9b6c41bc4ff 100644
>> --- a/gdb/common/agent.c
>> +++ b/gdb/common/agent.c
>> @@ -73,9 +73,16 @@ static struct ipa_sym_addresses ipa_sym_addrs;
>>
>> static int all_agent_symbols_looked_up = 0;
>>
>> +#ifdef GDBSERVER
>> +#include <inferiors.h>
>> +#endif
>> int
>> agent_loaded_p (void)
>> {
>> +#ifdef GDBSERVER
>> + if (current_thread == NULL)
>> + return 0;
>> +#endif
>> return all_agent_symbols_looked_up;
>> }
>>
>
> Please don't introduce "#ifdef GDBSERVER" conditionals into common
> code, I spent some time removing them last year. I know I didn't
> get them all, but the remaining two are on my hit list :)
Ok :)
I will check that.
thanks,
/ Henrik