This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Make GDB wait for events after handling target File-I/O

From: Luis Machado <lgustavo at codesourcery dot com>
To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
Date: Mon, 19 Oct 2015 11:37:19 -0200
Subject: Re: [PATCH] Make GDB wait for events after handling target File-I/O
Authentication-results: sourceware.org; auth=none
References: <1440723498-19075-1-git-send-email-lgustavo at codesourcery dot com> <55F17EC8 dot 5010906 at redhat dot com> <5621505F dot 8080506 at codesourcery dot com> <5624B633 dot 7030102 at redhat dot com> <5624EE71 dot 4070403 at codesourcery dot com> <5624EEFE dot 7010105 at redhat dot com>
Reply-to: Luis Machado <lgustavo at codesourcery dot com>

On 10/19/2015 11:24 AM, Pedro Alves wrote:

On 10/19/2015 02:21 PM, Luis Machado wrote:

On 10/19/2015 07:21 AM, Pedro Alves wrote:

On 10/16/2015 08:30 PM, Luis Machado wrote:

How does the attached update look?


Is there a reason to keep the "rs->waiting_for_stop_reply = 1;" lines?


No, that was a mistake since we inverted the logic. What about the
following?

Now we'll only set rs->waiting_for_stop_reply to 1 when resuming in
"all-stop" mode.


Thanks.  This version LGTM.


Thanks. Pushed now as 29090fb629734b7980f058f4a7e24a0369e9bb49.

References:
- Re: [PATCH] Make GDB wait for events after handling target File-I/O
  - From: Luis Machado
- Re: [PATCH] Make GDB wait for events after handling target File-I/O
  - From: Pedro Alves
- Re: [PATCH] Make GDB wait for events after handling target File-I/O
  - From: Luis Machado
- Re: [PATCH] Make GDB wait for events after handling target File-I/O
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]