This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH 17/17] infrun: scheduler-locking reverse
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, "Eli Zaretskii (eliz at gnu dot org)" <eliz at gnu dot org>
- Cc: Pedro Alves <palves at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 17 Sep 2015 08:47:28 +0000
- Subject: RE: [PATCH 17/17] infrun: scheduler-locking reverse
- Authentication-results: sourceware.org; auth=none
- References: <1441794909-32718-1-git-send-email-markus dot t dot metzger at intel dot com> <1441794909-32718-18-git-send-email-markus dot t dot metzger at intel dot com> <55F03A12 dot 80307 at redhat dot com> <20150912194344 dot GA7575 at host1 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B23331AE05D at IRSMSX104 dot ger dot corp dot intel dot com> <20150915171931 dot GA2056 at host1 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B23331AE557 at IRSMSX104 dot ger dot corp dot intel dot com> <20150917083856 dot GA8544 at host1 dot jankratochvil dot net>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Jan Kratochvil
> Sent: Thursday, September 17, 2015 10:39 AM
Hello Jan, Eli,
> OK, I get it now. I misunderstood it all despite word by word the new
> description is right. I would suggest changing the proposed:
>
> off == no locking (threads may preempt at any time)\n\
> on == full locking (no thread except the current thread may run)\n\
> step == scheduler locked during stepping commands (step, next, stepi,
> nexti).\n\
> reverse == scheduler locked during reverse/replay execution.\n\
>
> to:
>
> off == no locking (threads may preempt at any time)\n\
> on == full locking (no thread except the current thread may run)\n\
> This applies to both normal and reverse/replay execution.\n\
> step == scheduler locked during stepping commands (step, next, stepi,
> nexti).\n\
> This applies to both normal and reverse/replay execution.\n\
> reverse == scheduler fully locked only during reverse/replay execution.\n\
>
> And even gdb.texinfo somehow accordingly.
Fine with me. Eli, are you OK with the wording?
I already changed "reverse" into "replay" as discussed in a parallel thread.
I'm also using the terms "replay mode" and "record mode". I'm fine to change
them back into "reverse/replay execution" and "normal execution", which might
be clearer if you have not read the Record manual section.
Thanks,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928