This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch, testsuite] skip tests in with_target_charset if no ICONV support
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 15 Sep 2015 12:52:07 -0600
- Subject: [patch, testsuite] skip tests in with_target_charset if no ICONV support
- Authentication-results: sourceware.org; auth=none
If GDB is configured without ICONV support, it only knows about the
charset "ISO-8859-1". Tests that use with_target_charset with some
other character set (e.g., gdb.base/printcmds.exp) presumably depend on
exactly that character set being supported and can't be expected to work
properly in its absence. This patch makes with_target_charset skip
those tests as unsupported if switching to the specified character set
fails. OK to commit?
-Sandra
2015-09-15 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* lib/gdb.exp (with_target_charset): Skip tests as unsupported
if target_charset is not valid, e.g. due to no ICONV support.
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 56cde7a..747d66e 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2043,7 +2043,17 @@ proc with_target_charset { target_charset body } {
}
}
- gdb_test_no_output "set target-charset $target_charset" ""
+ # Setting the charset may fail if GDB was configured without
+ # ICONV support.
+ gdb_test_multiple "set target-charset $target_charset" "" {
+ -re "Undefined item.*$gdb_prompt " {
+ unsupported "Unknown charset $target_charset"
+ return -1
+ }
+ -re ".*$gdb_prompt " {
+ pass "set target-charset $target_charset"
+ }
+ }
set code [catch {uplevel 1 $body} result]