This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type


Patrick Palka <patrick@parcs.ath.cx> writes:
> [ The earlier committed version of this patch was reverted.  ]
>
> Since the type whose name is being set is now being allocated on the
> gdbarch obstack, we should allocate its TYPE_NAME on the obstack too.
> This reduces the number of individual valgrind warnings for the command
> "gdb gdb" from ~300 to ~150.
>
> Tested on x86_64-unknown-linux-gnu.
>
> gdb/ChangeLog:
>
> 	* gdb_obstack.h (obstack_strdup): Declare.
> 	* gdb_obstack.c (obstack_strdup): Declare.
> 	* gdbarch.sh (gdbarch_obstack_strdup): Declare and define.
> 	* gdbarch.c: Regenerate.
> 	* gdbarch.h: Regenerate.
> 	* gdbtypes.c (arch_type): Use gdbarch_obstack_strdup.

LGTM.
Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]