This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7] Merge async and sync code paths some more
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 27 Aug 2015 14:26:01 +0100
- Subject: Re: [PATCH 1/7] Merge async and sync code paths some more
- Authentication-results: sourceware.org; auth=none
- References: <1439398917-22761-1-git-send-email-palves at redhat dot com> <1439398917-22761-2-git-send-email-palves at redhat dot com> <86wpws3ma3 dot fsf at gmail dot com> <55D48E6B dot 7030903 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> Nope, not yet at least, though centralizing sigint handling in the event
> loop would probably be a good goal.
>
> It's actually still handled by set_sigint_trap -> inflow.c:pass_signal.
> The difference is that after this patch, linux_nat_terminal_inferior
> also calls set_sigint_trap itself in sync mode, so these call in
> linux_nat_wait_1 are no longer necessary. They actually become harmful,
> because set_sigint_trap/clear_sigint_trap are not idempotent.
> A sequence of calls like set_sigint_trap -> set_sigint_trap -> clear_sigint_trap
> ends up with the wrong SIGINT handler set...
OK, I see.
>
> Thanks, here's the patch that I plan to push, unless you have
> further comments.
I don't have comments, please go ahead.
--
Yao (éå)