This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Warn when accessing binaries from remote targets
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Andrew Burgess <andrew dot burgess at embecosm dot com>, Sandra Loosemore <sandra at codesourcery dot com>, Doug Evans <dje at google dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, André Pönitz <apoenitz at t-online dot de>, Paul_Koning at Dell dot com, Joel Brobecker <brobecker at adacore dot com>
- Date: Fri, 21 Aug 2015 16:41:43 +0100
- Subject: Re: [PATCH v2] Warn when accessing binaries from remote targets
- Authentication-results: sourceware.org; auth=none
- References: <20150811140440 dot GB24095 at blade dot nx> <1439472239-15866-1-git-send-email-gbenson at redhat dot com>
On 08/13/2015 02:23 PM, Gary Benson wrote:
> + if (warn_if_slow)
> + {
> + static int warning_issued = 0;
> +
> + printf_unfiltered (_("Reading %s from remote target...\n"),
> + filename);
> +
> + if (!warning_issued)
> + {
> + warning (_("File transfers from remote targets can be slow."
> + " Use \"set sysroot\" with no arguments to access"
> + " files locally instead."));
I wonder whether "with no arguments" is necessary here. I'd suggest dropping
that bit. It think it may even be confusing, as what the user should do is
point at a local copy of the target filesystem, using "set sysroot /path/to/copy".
The host's filesystem is not necessarily the correct one, and often isn't.
Otherwise this looks good to me.
Thanks,
Pedro Alves