This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Change type of struct complaints::series
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 06 Aug 2015 09:22:05 +0100
- Subject: Re: [PATCH] Change type of struct complaints::series
- Authentication-results: sourceware.org; auth=none
- References: <1438811079-25809-1-git-send-email-simon dot marchi at ericsson dot com>
On 08/05/2015 10:44 PM, Simon Marchi wrote:
> Found while processing the C++ enum changes. It seems like series
> should be of type enum complaint_series, instead of adding a cast.
>
> If somebody could guide me a little bit, I think I could clean up the
> comments around this. The comments on enum complaint_series and the
> series field seem redundant and maybe out of date. Do the "case N" in
> the comments refer to the enum values? If so they don't seem to match
> the actual values.
'git blame' is your friend. :-) Seems to me they do refer to
the enum values -- see b9caf505. That commit added the enum, and moved around
the "case N" comments. But, it also added a fourth state, and missed updating
the N numbers to account for it. E.g., "case 2: Subsequent message" is a typo
that should say "case 3". Definitely agreed that all these comments
are redundant.
>
> gdb/ChangeLog:
>
> * complaints.c (enum complaint_series): Add newlines.
> (struct complaints) <series>: Change type to enum
> complaint_series.
> (symfile_complaint_hook): Use equivalent enum value
> ISOLATED_MESSAGE instead of 0.
This is OK.
Thanks,
Pedro Alves