This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Replace the block_found global with explicit data-flow

From: Pierre-Marie de Rodat <derodat at adacore dot com>
To: Luis Machado <lgustavo at codesourcery dot com>, Doug Evans <xdje42 at gmail dot com>
Cc: GDB Patches <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
Date: Sat, 01 Aug 2015 21:35:58 +0200
Subject: Re: [PATCH] Replace the block_found global with explicit data-flow
Authentication-results: sourceware.org; auth=none
References: <55AE7520 dot 1010307 at adacore dot com> <55AE943F dot 3000009 at adacore dot com> <m3lhe4yls4 dot fsf at sspiff dot org> <55BA299D dot 7040407 at adacore dot com> <55BC89E6 dot 9040705 at adacore dot com> <55BC8CA9 dot 3070505 at adacore dot com> <55BC92D8 dot 8070407 at adacore dot com> <55BCEDF1 dot 2070806 at codesourcery dot com> <55BCF2E7 dot 9000800 at adacore dot com> <55BD0EDD dot 9040903 at codesourcery dot com>

On 08/01/2015 08:24 PM, Luis Machado wrote:

Understood: here's an updated patch introducing a temporary to do this.
Thank you!


Thanks!

I think you forgot to fix the other occurrences though.

Arg, sorry: I thought you were suggesting this to get rid of the weirdindentation behavior (hence my fix on the first occurence only).

At this point I wonder what to do: this patch indeed introduces some ofâfoo(..).barâ constructs, but my previous one introduced a _lot_ more.So my feeling is that the code will get bigger and less readable...that's my personal taste anyway. ;-) That being said, I'm completelyopen to settling on this style anyway, as long as we are aware of theconsequences.


--
Pierre-Marie de Rodat

Follow-Ups:
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Luis Machado

References:
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Pierre-Marie de Rodat
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Pierre-Marie de Rodat
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Pierre-Marie de Rodat
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Luis Machado
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Pierre-Marie de Rodat
- Re: [PATCH] Replace the block_found global with explicit data-flow
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]