This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Replace the block_found global with explicit data-flow


On 08/01/2015 01:25 PM, Pierre-Marie de Rodat wrote:
On 08/01/2015 06:04 PM, Luis Machado wrote:
+    sym = lookup_symbol (MDEBUG_EFI_SYMBOL_NAME, b, LABEL_DOMAIN,
+                 0).symbol;
      }

It is probably a matter of personal taste, but i find it easier and
cleaner to get the result of lookup_symbol (...) assigned to a variable
and then have the code access its 'symbol' field as opposed to chaining
things like the above.

The current codebase doesn't show many occurrences like the above.

Understood: here's an updated patch introducing a temporary to do this.
Thank you!


Thanks!

I think you forgot to fix the other occurrences though.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]