Re: [PATCH] gdb python LineTable.source_lines docstring returns List, not FrozenSet

[Ciro Santilli <ciro dot santilli at gmail dot com>]

Ping.

On Thu, Jul 23, 2015 at 9:31 PM, Ciro Santilli <ciro.santilli@gmail.com> wrote:
> Thanks!
>
> No worries: just checking that I'm following the usual group rules.
>
> I know that patches take time to review ;-)
>
> I will try to follow the rules more closely.
>
> About the copyright assignment, I'd like to do it, I will likely
> submit a few more small patches. How to proceed?
>
> I wish FSF would open the GPG option outside of the US... :-)
>
> On Thu, Jul 23, 2015 at 4:02 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Sorry for the delay in reviewing this. Thanks for the patch.
>>
>> Yes, weekly pings are absolutely appropriate. Thanks for the reminders!
>>
>>> >From 2edf562a17871d32b814acda9ced29856d405d6c Mon Sep 17 00:00:00 2001
>>> From: Ciro Santilli <ciro.santilli@gmail.com>
>>> Date: Sat, 4 Jul 2015 21:56:58 +0200
>>> Subject: [PATCH] gdb python LineTable.source_lines docstring returns List, not
>>>  FrozenSet
>>
>> Overall, the patch looked good, and I just pushed it after creating
>> a proper revision log and doing a round of testing (our penance
>> for letting your patch sit for a while).
>>
>> But if you are going to send more patches for inclusion, we'll need
>> you to have a copyright assignment on file. If you want to start
>> the process, let me know, and I will send you the form to fill.
>> For now, this patch was small and obvious enough that copyright
>> was not an issue.
>>
>> Also, we have a fairly detailed procedure for submitting patches.
>> We have a checklist:
>>
>>     https://sourceware.org/gdb/wiki/ContributionChecklist
>>
>> Once you have a copyright assignment on file, and your patch
>> submissions start following the procedure above, we can give you
>> write-after-approval access to the GDB repository.
>>
>> Attached is the patch as I pushed it...
>>
>> gdb/ChangeLog:
>>
>>         * py-linetable.c (ltpy_get_all_source_lines): Adjust function
>>         documentation to say that it returns a list rather than
>>         a FrozenSet.
>>         (linetable_object_methods): Update the docstring of the
>>         "source_line" entry.
>>
>> Tested on x86_64-linux.
>>
>> Thanks again for the patch.
>> --
>> Joel