This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/8] gen-pert-test: parallel build support
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: Doug Evans <xdje42 at gmail dot com>, Doug Evans <dje at google dot com>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 25 Jul 2015 19:21:08 -0400
- Subject: Re: [PATCH 5/8] gen-pert-test: parallel build support
- Authentication-results: sourceware.org; auth=none
- References: <001a11c301ba95cb5e051b62da63 at google dot com> <CA+C-WL_XUcyuqYQp4dSuzUgTUZk0DgLY76nc_9KGpLZ2zLjGdg at mail dot gmail dot com> <CAP9bCMQHpqa=zRvjupZZGfBCM=qbsuD3wQCkF2oEZwc0umZg=g at mail dot gmail dot com> <CA+C-WL-Uuhw646D6u3KgLoS_-VJLVemEvYfjjhBWjstoAvAPuQ at mail dot gmail dot com>
On Saturday, July 25 2015, Patrick Palka wrote:
>>> This patch seems to have caused a number of regressions:
>>>
>>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502
>>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501
>>> http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1510
>>>
>>> (possibly among others)
>>>
>>> Reverting this patch locally makes the regressions disappear for me,
>>> at least on x86_64-m64.
>>
>> I can't repro this.
>> It's odd that this patch would cause these particular regressions:
>>
>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501/steps/regressions/logs/regressions
>>
>> http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502/steps/regressions/logs/regressions
>>
>> Also, I don't understand this one:
>>
>> http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1420
>>
>> I can imagine makefile hacking for the perf tests breaking normal make check,
>> but then I'd expect the damage to be far more extensive, but the patch
>> reported in 1420 cannot have caused those regressions.
>
> In this case, the regressions listed for build 1420 originated from build 1417:
>
> http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/1417
>
> The baseline for checking for regressions is not the build before, but
> rather it's a "rolling" baseline or something like that.
Sorry, as it turns out I found a bug in the way BuildBot calculated the
regressions for the current build. Unfortunately it wasn't correctly
updating the previous_gdb.sum file, which is used to directly calculate
the regressions against the last build. The bug has been fixed now; it
has been introduced a few days ago, so not many builds have been
compromised. Also, the regressions reported *were* valid; the only
problem was that they were being reported over and over for every build.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/