This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/5] Update comments in struct value for non-8-bits architectures
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 24 Jul 2015 12:27:05 +0100
- Subject: Re: [PATCH 2/5] Update comments in struct value for non-8-bits architectures
- Authentication-results: sourceware.org; auth=none
- References: <1437072684-26565-1-git-send-email-simon dot marchi at ericsson dot com> <1437072684-26565-2-git-send-email-simon dot marchi at ericsson dot com>
On 07/16/2015 07:51 PM, Simon Marchi wrote:
> gdb/ChangeLog:
>
> * value.c (struct value): Update comments.
Looks good to me, though as mentioned in the other patch, I think
these comments should be explicit in saying "host" and "target". These are
central structures that people study first, and being crystal clear
should help grasp the byte vs memory units concepts sooner.
Thanks,
Pedro Alves