This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Sync readline/ to version 7.0 alpha
- From: Pedro Alves <palves at redhat dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>, gdb-patches at sourceware dot org
- Cc: eliz at gnu dot org
- Date: Fri, 24 Jul 2015 09:45:58 +0100
- Subject: Re: [PATCH] Sync readline/ to version 7.0 alpha
- Authentication-results: sourceware.org; auth=none
- References: <1436927724-4059-1-git-send-email-patrick at parcs dot ath dot cx>
On 07/15/2015 03:35 AM, Patrick Palka wrote:
> This patch syncs our upstream copy of readline from version 6.2 to the
> latest version, 7.0 alpha (released July 10 2015).
>
> I essentially copied what was done the last time readline was synced,
> when Jan updated to readline 6.2 in 2011:
> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
> Getting this kind of change in at the start of the GDB 7.11 development
> cycle will allow us to get a lot of passive testing from developers and
> from bleeding-edge users.
I agree; if this helps find readline issues that affect GDB before
readline is released, it'll be a win, because distros tend to use the
system readline instead of the one we bundle.
> [And as new versions of readline 7.0 are
> released, I will try to sync our local copy promptly.]
>
Thanks.
> Since the patch is too big to send inline, I pushed it to
> users/ppalka/readline-7.0-update. Hopefully that is more convenient that
> sending it as a compressed attachment.
Indeed it is. Thanks.
>
> readline/ChangeLog.gdb:
>
> Import readline 7.0 alpha
> * configure: Regenerate.
> * examples/rlfe/configure: Regenerate.
>
> gdb/ChangeLog:
>
> * completer.c (gdb_printable_part): Sync with readline function
> it is based off of.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.gdb/selftest.exp (test_with_self): Update test to now
> expect the GDB inferior to no longer immediately stop after
> being resumed with "signal SIGINT".
Looks good to me.
Thanks,
Pedro Alves