This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [testsuite patch] Fix testsuite regression by: Do not skip prologue for asm (.S) files
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Jul 2015 16:48:56 +0200
- Subject: Re: [testsuite patch] Fix testsuite regression by: Do not skip prologue for asm (.S) files
- Authentication-results: sourceware.org; auth=none
- References: <20150629163708 dot GA28795 at host1 dot jankratochvil dot net> <86lheol7wz dot fsf at gmail dot com> <20150710114743 dot GA12225 at host1 dot jankratochvil dot net> <868uaokrqw dot fsf at gmail dot com>
On Fri, 10 Jul 2015 16:32:39 +0200, Yao Qi wrote:
> I don't know such convention of writing changelog entry for .exp changes.
> We usually put the proc or variable name into the parenthesis, like,
>
> * gdb.foo/bar.exp (proc_name): XXXX
That also happenes/ed.
> Is it documented somewhere?
I do not know, in GDB I always follow past practices (which are not always
good):
2011-05-20 Pierre Muller <muller@ics.u-strasbg.fr>
[...]
* gdb.base/default.exp (show convenience): Use double
^^^^^^^^^^^^^^^^
quote pattern for regular expressions.
[...]
2011-01-09 Andreas Schwab <schwab@linux-m68k.org>
* gdb.threads/tls.exp ("info address me"): Fix expected output.
^^^^^^^^^^^^^^^
Somehow I think the intention of the ChangeLog entries is to identify where
the change happened, so both test case name or subroutine name is appropriate,
depending on what matches better. At least I saw it so before.
Jan