This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7] Split c_val_print
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 9 Jul 2015 11:28:23 -0400
- Subject: Re: [PATCH 0/7] Split c_val_print
- Authentication-results: sourceware.org; auth=none
- References: <1436389629-18754-1-git-send-email-simon dot marchi at ericsson dot com> <559E52B1 dot 9020802 at redhat dot com>
On 15-07-09 06:53 AM, Pedro Alves wrote:
> Nice! A couple issues need to be fixed and this is good to go.
>
> - The intro comment to print_unpacked_pointer in patch 2
> uses the wrong format (leading * in each line?).
Ah, that's an artifact from CDT :). Fixed.
> - For convention, make sure there's a line break after
> each variable declaration.
You mean, after each block of variable declarations, and not
after each single variable declaration I suppose?
I only found one instance, in c_val_print_ptr.
> Fix these and push.
Done, thanks.
> Thanks,
> Pedro Alves