This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 4/8] [AArch64] Teach prologue unwinder to terminate gracefully


On 09/07/15 13:46, Yao Qi wrote:
> Pierre Langlois <pierre.langlois@arm.com> writes:
> 
>> +/* Allocate and fill in *THIS_CACHE with information about the prologue of
>> +   *THIS_FRAME.  Do not do this is if *THIS_CACHE was already allocated.
>> +   Return a pointer to the current aarch64_prologue_cache in *THIS_CACHE.
>> +   */
> 
> We don't write */-only line in the comment.  See "Block Comment Formatting"
> in https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
> 
> You can change it to
>       ...
>       *THIS_CACHE.  */
> 

Oh I see, sorry I missed this.  I'll update this comment on the other
patches too.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]