This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 4/8] [AArch64] Teach prologue unwinder to terminate gracefully
- From: Pierre Langlois <pierre dot langlois at arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: pierre dot langlois at arm dot com, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 09 Jul 2015 13:51:43 +0100
- Subject: Re: [PATCH v2 4/8] [AArch64] Teach prologue unwinder to terminate gracefully
- Authentication-results: sourceware.org; auth=none
- References: <86pp42mxbz dot fsf at gmail dot com> <1436438962-2794-1-git-send-email-pierre dot langlois at arm dot com> <86vbdtlcqr dot fsf at gmail dot com>
On 09/07/15 13:46, Yao Qi wrote:
> Pierre Langlois <pierre.langlois@arm.com> writes:
>
>> +/* Allocate and fill in *THIS_CACHE with information about the prologue of
>> + *THIS_FRAME. Do not do this is if *THIS_CACHE was already allocated.
>> + Return a pointer to the current aarch64_prologue_cache in *THIS_CACHE.
>> + */
>
> We don't write */-only line in the comment. See "Block Comment Formatting"
> in https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
>
> You can change it to
> ...
> *THIS_CACHE. */
>
Oh I see, sorry I missed this. I'll update this comment on the other
patches too.