This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [gdbserver, aarch64] Set userregs to NULL in regs_info
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 09 Jul 2015 12:26:24 +0100
- Subject: Re: [PATCH] [gdbserver, aarch64] Set userregs to NULL in regs_info
- Authentication-results: sourceware.org; auth=none
- References: <1436440940-11732-1-git-send-email-yao dot qi at linaro dot org>
Typo in subject: "usrregs".
On 07/09/2015 12:22 PM, Yao Qi wrote:
> Hi,
> I happen to read the comments in regs_info below,
>
> struct regs_info
> {
> ...
> /* Info used when accessing registers with PTRACE_PEEKUSER /
> PTRACE_POKEUSER. This can be NULL if all registers are
> transferred with regsets .*/
> struct usrregs_info *usrregs;
>
> that usrregs can be NULL if all registers are transferred with
> regsets, which is exactly what aarch64-linux does. This patch
> is to set userregs to NULL in regs_info and remove
> aarch64_usrregs_info and aarch64_regmap.
>
> Regression tested on aarch64-linux with GDBserver.
>
> gdb/gdbserver:
>
> 2015-07-09 Yao Qi <yao.qi@linaro.org>
>
> * linux-aarch64-low.c (aarch64_regmap): Remove.
> (aarch64_usrregs_info): Remove.
> (regs_info): Set field userregs to NULL.
OK.
Thanks,
Pedro Alves