This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/8] [AArch64] Refactor aarch64_make_prologue_cache
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pierre Langlois <pierre dot langlois at arm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 08 Jul 2015 17:08:59 +0100
- Subject: Re: [PATCH 1/8] [AArch64] Refactor aarch64_make_prologue_cache
- Authentication-results: sourceware.org; auth=none
- References: <1436273518-5959-1-git-send-email-pierre dot langlois at arm dot com> <1436273518-5959-2-git-send-email-pierre dot langlois at arm dot com>
Pierre Langlois <pierre.langlois@arm.com> writes:
> static struct aarch64_prologue_cache *
> -aarch64_make_prologue_cache (struct frame_info *this_frame)
> +aarch64_make_prologue_cache (struct frame_info *this_frame, void
> **this_cache)
Could you document this function? add comments about it, its
arguments, and return value.
> {
> struct aarch64_prologue_cache *cache;
> CORE_ADDR unwound_fp;
> int reg;
>
> + if (*this_cache)
> + return *this_cache;
> +
Please check NULL explicitly, like if (*this_cache != NULL), see
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
OK with these changes.
--
Yao (éå)