This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Roland McGrath <mcgrathr at google dot com>, GDB <gdb-patches at sourceware dot org>
- Date: Fri, 29 May 2015 17:29:06 +0100
- Subject: Re: [PATCH users/roland/osabi-assert] Do not crash on unrecognized GNU .note.ABI-tag values
- Authentication-results: sourceware.org; auth=none
- References: <CAB=4xhoR0=ZaDot6rEaVhhEAxYeoBjP89AHhxgD52ANKKrDYJg at mail dot gmail dot com> <55683A6F dot 2030600 at redhat dot com> <CADPb22T2TU-zaAbuu0qa5yrOdsBVjXVHfezOVYbuKL+8zP7twg at mail dot gmail dot com>
On 05/29/2015 05:26 PM, Doug Evans wrote:
> On Fri, May 29, 2015 at 3:07 AM, Pedro Alves <palves@redhat.com> wrote:
>> On 05/29/2015 01:21 AM, Roland McGrath wrote:
>>> Diagnosis of unexpected input (in this case, in an executable file)
>>> should not crash as if it were a bug in GDB.
>>> ...
>>> + warning ("GNU ABI tag value %u unrecognized.\n", abi_tag);
>>
>> Wrap string in _().
>
> No trailing \n too, right?
Right.
Thanks,
Pedro Alves