This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support
- From: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 27 May 2015 12:54:38 -0300
- Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support
- Authentication-results: sourceware.org; auth=none
- References: <1432041752-4638-1-git-send-email-yao dot qi at linaro dot org> <1432041752-4638-3-git-send-email-yao dot qi at linaro dot org> <555E3EAE dot 2080107 at redhat dot com> <86h9qzr2g2 dot fsf at gmail dot com> <5564D0E9 dot 3000402 at linux dot vnet dot ibm dot com> <86d21mqvl0 dot fsf at gmail dot com> <868ucaqq0o dot fsf at gmail dot com> <5565D0B8 dot 7090602 at linux dot vnet dot ibm dot com> <86zj4qoyd3 dot fsf at gmail dot com>
On 05/27/2015 12:04 PM, Yao Qi wrote:
> Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:
>
>> unfortunately I was unable to apply your patch due to the follow:
>>
>
> I copy my patch from thunderbird, and paste it in 2.path. I have no
> trouble applying it.
>
>> $ patch -p1 -i ~/fix.patch --dry
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> checking file gdb/aarch64-tdep.c
>> patch: **** malformed patch at line 6: *aarch64_insn_r)
>
> Does your editor split the line in patch like this?
>
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 8597497..d07b26c 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3592,7 +3592,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record
> *aarch64_insn_r)
> ^^^^^^^^^^^^^^^
>
> it should be in previous line.
>
I also use thunderbird, but usually I save the raw message instead of
copying to avoid miscopies. But I managed to apply the patch after
copying it as you suggested and checked that it fixes the build issue.
Btw, I'm using gcc 4.8.3 for these tests.
Thanks!
--
Edjunior