This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/9 v2] Comment and whitespace changes
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Eli Zaretskii <eliz at gnu dot org>, Doug Evans <dje at google dot com>, Iago López Galeiras <iago at endocode dot com>
- Date: Thu, 21 May 2015 15:57:01 +0100
- Subject: Re: [PATCH 4/9 v2] Comment and whitespace changes
- Authentication-results: sourceware.org; auth=none
- References: <1429186791-6867-1-git-send-email-gbenson at redhat dot com> <1430395542-16017-5-git-send-email-gbenson at redhat dot com>
On 04/30/2015 01:05 PM, Gary Benson wrote:
> Comments on the various implementations of target fileio functions
> duplicate information documented in target.h. This commit replaces
> the duplicated documentation with breadcrumbs, and inserts blank
> lines to separate comments from the functions they describe where
> necessary.
>
> gdb/ChangeLog:
>
> * inf-child.c (inf_child_fileio_open): Replace comment.
> (inf_child_fileio_pwrite): Likewise.
> (inf_child_fileio_pread): Likewise.
> (inf_child_fileio_fstat): Insert blank line before comment.
> (inf_child_fileio_close): Replace comment.
> (inf_child_fileio_unlink): Likewise.
> (inf_child_fileio_readlink): Likewise.
> * remote.c (remote_hostio_open): Likewise.
> (remote_hostio_pread): Likewise.
> (remote_hostio_pwrite): Likewise.
> (remote_hostio_close): Likewise.
> (remote_hostio_unlink): Likewise.
> (remote_hostio_readlink): Likewise.
> (remote_hostio_fstat): Likewise.
> (remote_filesystem_is_local): Likewise.
> * target.c (target_fileio_open): Likewise.
> (target_fileio_pwrite): Likewise.
> (target_fileio_pread): Likewise.
> (target_fileio_fstat): Insert blank line before comment.
> (target_fileio_close): Replace comment.
> (target_fileio_unlink): Likewise.
> (target_fileio_readlink): Likewise.
> (target_fileio_read_alloc): Likewise.
> (target_fileio_read_stralloc): Likewise.
OK.
Thanks,
Pedro Alves