This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb: Add completer for layout command.
- From: Keith Seitz <keiths at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 20 May 2015 17:19:54 -0700
- Subject: Re: [PATCH 2/2] gdb: Add completer for layout command.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1428011044 dot git dot andrew dot burgess at embecosm dot com> <18d55b2f3d6b65fd7e1fef8374fbadf429e95095 dot 1428011044 dot git dot andrew dot burgess at embecosm dot com> <555B3CCD dot 7040003 at redhat dot com> <20150520232246 dot GF2880 at embecosm dot com>
On 05/20/2015 04:22 PM, Andrew Burgess wrote:
> As a bonus the new completion part of the new series is simpler and
> so should not clash with Keith's work.
I wouldn't worry too much about collisions anyway. My patch is so large,
it will likely take considerable time to be reviewed.
Even so, the change to any completer is fairly trivial. Add a parameter
and use add_completion, returning if it is a certain value. Your layout
completer would be trivial to convert.
Thank you for keeping an eye out, though. I've been through a lot of
rebasing nightmares in the last few months as I try to keep two large
patchsets in shape.
Keith