This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Handle unbuffered Guile memory ports, and zero sized ports
- From: Doug Evans <xdje42 at gmail dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 16 May 2015 12:21:40 -0700
- Subject: Re: [PATCH] Handle unbuffered Guile memory ports, and zero sized ports
- Authentication-results: sourceware.org; auth=none
- References: <m31tk8k7x8 dot fsf at sspiff dot org> <83lhifzugv dot fsf at gnu dot org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Doug Evans <xdje42@gmail.com>
>> Date: Sat, 28 Mar 2015 16:40:19 -0700
>>
>> This patch adds support for unbuffered Guile memory supports,
>> and allows for zero sized ports.
>>
>> Regression tested on amd64-linux.
>>
>> 2015-03-28 Doug Evans <xdje42@gmail.com>
>>
>> * NEWS: Mention support for unbuffered Guile memory ports.
>> * scm-ports.c (ioscm_memory_port): Update comments on end, size.
>> (ioscm_lseek_address): Improve overflow calculation.
>> (gdbscm_memory_port_fill_input): Add assert.
>> (gdbscm_memory_port_write): Handle unbuffered ports.
>> Handle large writes identical to Guile's fport_write.
>> (gdbscm_memory_port_seek): Fix seeking past end check.
>> (gdbscm_memory_port_close): Handle closing unbuffered port.
>> (ioscm_parse_mode_bits): Recognize "0" for unbuffered ports.
>> (ioscm_init_memory_port): Handle unbuffered ports.
>> (ioscm_reinit_memory_port): Ditto.
>> (ioscm_init_memory_port): Update size calculation.
>> (gdbscm_open_memory): Support zero sized ports.
>>
>> testsuite/
>> * gdb.guile/scm-ports.c: New file.
>> * gdb.guile/scm-ports.exp: Add memory port tests.
>>
>> doc/
>> * guile.texi (Memory Ports in Guile): Document support for unbuffered
>> memory ports.
>
> OK for the documentation parts.
>
> Thanks.
Thanks. Committed.