This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [RFC] Sync readline to version 6.3 patchlevel 8
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Doug Evans <dje at google dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Sat, 16 May 2015 11:50:14 -0400
- Subject: Re: [PATCH] [RFC] Sync readline to version 6.3 patchlevel 8
- Authentication-results: sourceware.org; auth=none
- References: <1431562331-20448-1-git-send-email-patrick at parcs dot ath dot cx> <CADPb22RQi=S3ygBGL-b5+XD=Eyz+aKeQXmjE+5iSiazA-=4M7Q at mail dot gmail dot com> <CA+C-WL9Nqa7G4Wh1kszePEjQ5HwFNT5MsX+J5GFCswNDY1GPVQ at mail dot gmail dot com> <CADPb22SQpS1qwJ-uWQ+=JC-Z62YQBY9xGjxMRpx-2oEQHMuyiA at mail dot gmail dot com> <20150516152514 dot GA12510 at host1 dot jankratochvil dot net>
On Sat, May 16, 2015 at 11:25 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Sat, 16 May 2015 17:23:23 +0200, Doug Evans wrote:
>> Another thought is that IWBN if the reapplication of local patches was
>> a separate commit.
>
> IIUC this would break git bisect.
Unless the local patch fixes a major issue (or perhaps a build error),
I don't think separately reapplying local patches would "break" git
bisect but it would possibly introduce temporary readline-related
testsuite regressions which are not relevant unless you're already
bisecting a readline-related issue. I haven't used git bisect so I
may be wrong... But if that's the case then IMO it's worth the
"breakage".