This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v4 5/5] Update documentation on catching a group of related syscalls.
- From: Pedro Alves <palves at redhat dot com>
- To: Gabriel Krisman Bertazi <gabriel at krisman dot be>, sergiodj at redhat dot com
- Cc: gdb-patches at sourceware dot org, dje at google dot com
- Date: Wed, 13 May 2015 11:29:56 +0100
- Subject: Re: [PATCH v4 5/5] Update documentation on catching a group of related syscalls.
- Authentication-results: sourceware.org; auth=none
- References: <87wq0gtfxu dot fsf at redhat dot com> <1431304069-19647-1-git-send-email-gabriel at krisman dot be> <1431304069-19647-6-git-send-email-gabriel at krisman dot be> <874mnkhrpw dot fsf at krisman dot be>
On 05/11/2015 01:40 AM, Gabriel Krisman Bertazi wrote:
> Gabriel Krisman Bertazi <gabriel@krisman.be> writes:
>
>> gdb/
>>
>> * break-catch-syscall.c (_initialize_breakpoint): Update catch
>> syscall command documentation.
>> * NEWS: Include section about catching groups of syscalls.
>>
>> gdb/doc/
>>
>> * gdb.texinfo (Set Catchpoints): Add 'group' argument to catch
>> syscall.
>
> Oops,
>
> Sorry, I sent the documentation patch again. Please, ignore this one,
> Eli already approved it twice. :)
Generally, personally, in such cases, I prefer that an already approved patch
is included in the series. That is, it makes it easier for people to review
the whole series on its own. Don't assume that people still have context
on previous discussions and patches in their heads. For example, I didn't
really follow v1 and v2 closely (was OOO when most of the discussions
happened, I think), and when I saw v3 I had to go hunt for the
documentation patch. You can just mention in the patch intro that it is
already approved.
Thanks,
Pedro Alves