This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Fix coredump-filter.exp by correctly unsetting array (was: Re: [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Luis Machado <lgustavo at codesourcery dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Thu, 07 May 2015 13:05:13 -0400
- Subject: [PATCH] Fix coredump-filter.exp by correctly unsetting array (was: Re: [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code)
- Authentication-results: sourceware.org; auth=none
- References: <1429889336-12277-1-git-send-email-qiyaoltc at gmail dot com> <554A3D61 dot 8090302 at redhat dot com> <554A44B9 dot 3090503 at codesourcery dot com> <86sib8vjtv dot fsf at gmail dot com> <554B4223 dot 1000003 at codesourcery dot com> <554B702F dot 5090006 at codesourcery dot com>
On Thursday, May 07 2015, Luis Machado wrote:
> Besides that, without the conditional block i also see a problem with
> the existing testcase using coredump_var_addr as an array but
> declaring it as a regular variable. It causes a number of errors. Did
> you notice that? Maybe it is specific to a certain version of expect.
>
> # Obtain the address of each variable that will be checked on each
> # case.
> set coredump_var_addr ""
> foreach item $all_anon_corefiles {
> foreach name [list [lindex $item 3] [lindex $item 4]] {
> set test "print/x $name"
> gdb_test_multiple $test $test {
> -re " = \($hex\)\r\n$gdb_prompt $" {
> set coredump_var_addr($name) $expect_out(1,string)
> }
> }
> }
> }
Thanks for catching this.
This is because of the discussion on:
<https://sourceware.org/ml/gdb-patches/2015-04/msg00452.html>
And the patch:
<https://sourceware.org/ml/gdb-patches/2015-04/msg00979.html>
It seems it is not possible to "clear" the variable using "" and then
use as an array. I think the best way would be to call 'unset
-nocomplain' in this case. The following patch does this. With it
applied, the test fully passes on Fedora 20 x86_64 native.
WDYT?
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
gdb/testsuite/ChangeLog:
2015-05-07 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.base/coredump-filter.exp: Correctly unset
"coredump_var_addr" array.
diff --git a/gdb/testsuite/gdb.base/coredump-filter.exp b/gdb/testsuite/gdb.base/coredump-filter.exp
index 72f756a..c601939 100644
--- a/gdb/testsuite/gdb.base/coredump-filter.exp
+++ b/gdb/testsuite/gdb.base/coredump-filter.exp
@@ -170,7 +170,7 @@ gdb_test_multiple "print/x &main" "getting main's address" {
# Obtain the address of each variable that will be checked on each
# case.
-set coredump_var_addr ""
+unset -nocomplain coredump_var_addr
foreach item $all_anon_corefiles {
foreach name [list [lindex $item 3] [lindex $item 4]] {
set test "print/x $name"