This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5 8/9] sim/erc32: Add data watchpoint support.

On 03 Apr 2015 22:35, Jiri Gaisler wrote:
> 	* exec.c (wpmask): New function to calculate address mask.
> 	(dispatch_instruction): send WPT_TRAP when breakpoint is hit. Check on

capitialize sentences -- "Send" here.  comes up multiple times.

> +static unsigned char
> +wpmask (uint32 op3)
> +{
> +    switch (op3 & 3) {
> +      case 0: return 3;  /* word */
> +      case 1: return 0;  /* byte */
> +      case 2: return 1;  /* half-word */
> +      case 3: return 7;  /* double word */
> +    }
> +}

indentation needs fixing

> +int
> +check_wpw(struct pstate *sregs, int32 address, unsigned char mask)

space before the (
-mike

Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]