This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] return zero in arm_linux_can_use_hw_breakpoint if HW point isn't supported
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Fri, 17 Apr 2015 12:12:06 +0100
- Subject: Re: [PATCH] return zero in arm_linux_can_use_hw_breakpoint if HW point isn't supported
- Authentication-results: sourceware.org; auth=none
- References: <1429263600-4098-1-git-send-email-qiyaoltc at gmail dot com>
On 04/17/2015 10:40 AM, Yao Qi wrote:
> From: Yao Qi <yao.qi@linaro.org>
>
> This patch is to cherry-pick part of Pedro's patch here
> https://sourceware.org/ml/gdb-patches/2015-04/msg00527.html in which
> zero is returned if the HW point isn't supported.
>
> In arm-linux native gdb testing on a board doesn't support HW breakpoint,
> without this patch, the output in gdb.base/breakpoint-in-ro-region.exp is like:
>
> (gdb) hbreak *0x83bc^M
> Hardware breakpoints used exceeds limit.^M
> (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: probe hbreak support (support)
>
> with this patch, the output becomes:
>
> (gdb) hbreak *0x83bc^M
> No hardware breakpoint support in the target.^M
> (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: probe hbreak support (no support)
>
> As a result, the following fails are fixed.
>
> -FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: step in ro region (cannot insert hw break)
> -FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: thread advanced
> -FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: step in ro region (cannot insert hw break)
> -FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: thread advanced
>
Great, thanks for doing this. Looks good to me, FWIW. :-)
Thanks,
Pedro Alves