This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Import strtok_r gnulib module
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 09 Apr 2015 10:10:19 +0100
- Subject: Re: [PATCH 2/2] Import strtok_r gnulib module
- Authentication-results: sourceware.org; auth=none
- References: <1428513587-8471-1-git-send-email-palves at redhat dot com> <1428513587-8471-3-git-send-email-palves at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> gdb/linux-tdep.c recently gained a strtok_r use. That broke
> --enable-targets=all with some versions of mingw64, which don't have
> strtok_r:
>
> https://sourceware.org/ml/gdb-patches/2015-04/msg00266.html
>
> Fix that by importing the strtok_r gnulib module.
Patch is OK to me.
>
> gdb/ChangeLog:
> 2015-04-08 Pedro Alves <palves@redhat.com>
>
> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add strtok_r.
> * gnulib/Makefile.in (aclocal_m4_deps): Add import/m4/strtok_r.m4.
Nit: gnulib/Makefile.in is regenerated, isn't? If so, "Regenerate"
should be used too.
> * gnulib/configure, gnulib/config.in, gnulib/aclocal.m4: Regenerate.
> * gnulib/import/Makefile.am: Update.
> * gnulib/import/Makefile.in: Update.
> * gnulib/import/m4/gnulib-cache.m4: Update.
> * gnulib/import/m4/gnulib-comp.m4: Update.
> * gnulib/import/m4/strtok_r.m4: New file.
> * gnulib/import/strtok_r.c: New file.
--
Yao (éå)