This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [rfc, spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init

From: Yao Qi <qiyaoltc at gmail dot com>
To: Ulrich Weigand <uweigand at de dot ibm dot com>, Pedro Alves <palves at redhat dot com>
Cc: Peter Schauer <peterschauer at gmx dot net>, gdb-patches at sourceware dot org
Date: Wed, 08 Apr 2015 16:06:45 +0100
Subject: Re: [rfc, spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init
Authentication-results: sourceware.org; auth=none
References: <201504071245 dot t37CjfGk007933 at d06av02 dot portsmouth dot uk dot ibm dot com>

On 07/04/15 13:45, Ulrich Weigand wrote:

It's been set since spu-tdep.c was committed upstream, and in
fact it's set in every single version in our internal repositories
of the code before it went upstream, too.  (Going back over 10 years.)

But I don't know why it was added either, since SPU has been using
software single-step forever too, and even the very first version of
GDB we patched to support SPU would ignore cannot_step_breakpoint
for software single-step architectures ...

So I'd say just go ahead and remove it.


Patch is pushed in.

--
Yao (éå)

References:
- Re: [rfc, spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]