This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section
- From: Doug Evans <dje at google dot com>
- To: Petr Machata <pmachata at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 30 Mar 2015 13:00:25 -0700
- Subject: Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section
- Authentication-results: sourceware.org; auth=none
- References: <87619mkpil dot fsf at redhat dot com> <21785 dot 37797 dot 271814 dot 469027 at ruffy2 dot mtv dot corp dot google dot com> <87pp7qjmh8 dot fsf at redhat dot com>
On Mon, Mar 30, 2015 at 12:48 PM, Petr Machata <pmachata@redhat.com> wrote:
> Doug Evans <dje@google.com> writes:
>
>> > + if { "$label" != "" } {
>> > + $label:
>> > + }
>>
>> Should this be:
>>
>> if { "$label" != "" } {
>> _emit "$label:"
>> }
>
> No, it's calling the function named "$label:". To define the label that
> the user supplied. Would this make it clearer?
>
> --- a/gdb/testsuite/lib/dwarf.exp
> +++ b/gdb/testsuite/lib/dwarf.exp
> @@ -1165,6 +1165,7 @@ namespace eval Dwarf {
> _section $section
>
> if { "$label" != "" } {
> + # Define the user-provided label at this point.
> $label:
> }
>
>
> Thanks,
> Petr
That helps enough.
Thanks.