This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] Implement support for checking /proc/PID/coredump_filter
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 19 Mar 2015 10:41:45 +0000
- Subject: Re: [PATCH 3/4] Implement support for checking /proc/PID/coredump_filter
- Authentication-results: sourceware.org; auth=none
- References: <1426707523-6499-1-git-send-email-sergiodj at redhat dot com> <1426707523-6499-4-git-send-email-sergiodj at redhat dot com>
On 03/18/2015 07:38 PM, Sergio Durigan Junior wrote:
> + /* If a mapping should not be dumped we still should create
> + a segment for it, just without SEC_LOAD (see
> + gcore_create_callback). */
I think this comment is stale now?
> + if (has_anonymous)
> + {
> + if (dump_mapping_p (filterflags, &v, private, mapping_anon_p,
> + filename))
> + modified_state = MEMORY_MAPPING_MODIFIED;
> + else
> + modified_state = MEMORY_MAPPING_UNMODIFIED;
> + }
> + else
> + {
> + /* Older Linux kernels did not support the "Anonymous:" counter.
> + If it is missing, we can't be sure - dump all the pages. */
> + modified_state = MEMORY_MAPPING_UNKNOWN_STATE;
> + }
Thanks,
Pedro Alves