Re: [PATCH 4/8] remote+docs: software/hardware breakpoint traps

[Eli Zaretskii <eliz at gnu dot org>]

> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 26 Feb 2015 00:17:28 +0000
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index b79b162..e70bea0 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -63,6 +63,16 @@ qXfer:btrace-conf:read
>  Qbtrace-conf:bts:size
>    Set the requested ring buffer size for branch tracing in BTS format.
>  
> +swbreak stop reason
> +  Indicates a memory breakpoint instruction was executed, irrespective
> +  of whether it was GDB that planted the breakpoint or the breakpoint
> +  is hardcoded in the program.  This is required for correct non-stop
> +  mode operation.
> +
> +hwbreak stop reason
> +  Indicates the target stopped for a hardware breakpoint.  This is
> +  required for correct non-stop mode operation.
> +
>  * The info record command now shows the recording format and the
>    branch tracing configuration for the current thread when using
>    the btrace record target.

This part is OK.

> +@item swbreak
> +This feature indicates whether @value{GDBN} supports the swbreak stop
> +reason in stop replies.  See @xref{swbreak stop reason}, for details.
> +
> +@item hwbreak
> +This feature indicates whether @value{GDBN} supports the hwbreak stop
> +reason in stop replies.  See @xref{swbreak stop reason}, for details.
                            ^^^^^^^^^
@xref should always be at the beginning of a sentence, as it generates
text that starts with a capital letter.  I think you meant @ref here.

> +If the stub supports non-stop mode, it should also support the
> +@samp{swbreak} stop reason if software breakpoints are supported, and
> +the @samp{hwbreak} stop reason if software breakpoints are supported
                                     ^^^^^^^^
"hardware", I guess.

Otherwise, OK for the documentation parts.  Thanks.