This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V4 7/9] Simple testsuite for DTrace USDT probes.


On Monday, February 16 2015, I wrote:

> On Monday, February 02 2015, Jose E. Marchesi wrote:
>
>> This patch adds some simple tests testing the support for DTrace USDT
>> probes.  The testsuite will be skipped as unsupported in case the user
>> does not have DTrace installed on her system.  The tests included in the
>> test suite test breakpointing on DTrace probes, enabling and disabling
>> probes, printing of probe arguments of several types and also
>> breakpointing on several probes with the same name.
>
> Thanks again for this awesome testcase.  I don't have any more comments
> to make about the patch itself; I personally liked your way of solving
> the transform problem, though I have a preference to see those changes
> in a different patch (i.e., not in the DTrace series).  Do you think you
> can do that?  It should be really easy to extract this part from your
> patch; and then, you'd only have to worry about the dtrace-side of it.
>
> I can't give you an approval for the transform.m4 thing, but for the
> rest, you have an OK.

I forgot to add Pedro in the loop.  Pedro, do you have any comments
about this?

Thanks,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]