This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
- From: Chen Gang S <gang dot chen at sunrus dot com dot cn>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Doug Evans <xdje42 at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 09 Feb 2015 09:56:00 +0800
- Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
- Authentication-results: sourceware.org; auth=none
- References: <54D61EFC dot 3040000 at sunrus dot com dot cn> <CAP9bCMT1=7ufFF0hBuTre8VJSMOJBxMHKk77V7+wkymKd9fQVw at mail dot gmail dot com> <54D6A794 dot 7080107 at sunrus dot com dot cn> <CAP9bCMQUMXWOmicLmHajeKBPXmdybdZgtq9WW-z5fAa+ks4dBQ at mail dot gmail dot com> <54D6BE70 dot 2080708 at sunrus dot com dot cn> <20150208160010 dot GE4738 at adacore dot com>
On 2/9/15 00:00, Joel Brobecker wrote:
>>>>>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com>
>>>>>>
>>>>>> * mcore/interp.c: Include "unistd.h" standard C header file to
>>>>>> avoid compiling warnings.
>
> A couple of small procedural nits...
>
> There is a ChangeLog file in sim/mcore, so this is the one that
> should be updated, and thus the name of the file in the ChangeLog
> entry should not have the "mcore/" part.
>
> Also, the ChangeLog entry should only say "what" has been changed,
> not "why". If you feel that the "why" needs to be provided, it should
> be provided in the code. In this case, I feel that your revision log
> is sufficient.
>
> So, your ChangeLog entry should look like:
>
> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com>
>
> * interp.c: Include "unistd.h".
OK, thanks. I guess, before "git push", I need send patch v2 to mailing
list.
If no any additional reply, I shall send patch v2 within 2015-02-10.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed