This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Chen Gang S <gang dot chen at sunrus dot com dot cn>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 3 Feb 2015 06:50:01 +0400
- Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
- Authentication-results: sourceware.org; auth=none
- References: <54CC0E99 dot 1070501 at sunrus dot com dot cn> <54CC2C8E dot 4090308 at eagerm dot com> <54CFD3F5 dot 5080508 at sunrus dot com dot cn>
Chen,
> >> 2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>
> >>
>
> Oh, sorry, the ChangeLog should use 2015-01-31 instead of 2014-01-31 for
> the all related 4 patches. I shall send patch v2 for them.
One important thing to watch out for: I think you may not have realized
that you pushed all 3 patches, whereas only the last one was approved.
So, the first two ones weren't expected to be pushed yet. If you need
help with git on how to push just the patches you want, let us know.
One way, for instance, is to work in a separate branch, and then
cherry-pick on master the patches only at the time where you want
to push them. That's what I do, and prevents this kind of accident
from happening.
In the meantime, since the patches have been pushed, I reviewed them
and they look good to me. So no need to revert. Normally, those are
reviewed by the sim maintainer, so he may have additional comments.
--
Joel