This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix compilation of dyn_arrayidx ada testcase
- From: Doug Evans <xdje42 at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 31 Jan 2015 14:28:32 -0800
- Subject: Re: [PATCH] Fix compilation of dyn_arrayidx ada testcase
- Authentication-results: sourceware.org; auth=none
- References: <m3lhks9bts dot fsf at sspiff dot org> <20150129074201 dot GG5193 at adacore dot com>
Joel Brobecker <brobecker@adacore.com> writes:
>> 2015-01-24 Doug Evans <xdje42@gmail.com>
>>
>> * gdb.ada/dyn_arrayidx.exp: Add additional_flags=-gnat12.
>
> Thanks for the fix, Doug. I didn't see this, because we changed our
> compiler to build with -gnat12 by default. This is an Ada Front End
> change, so I would assume that this made it to the FSF GCC by now;
> just don't know which version.
>
> Looking at the testcase, it would have been easy to adjust it to avoid
> that Ada 2012 feature. But since your fix is really easy, might as well
> keep it that way.
>
> OK to push if you haven't already.
>
>> diff --git a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
>> index 25351db..06702b8 100644
>> --- a/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
>> +++ b/gdb/testsuite/gdb.ada/dyn_arrayidx.exp
>> @@ -19,7 +19,7 @@ if { [skip_ada_tests] } { return -1 }
>>
>> standard_ada_testfile foo
>>
>> -if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug}] != ""} {
>> +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable {debug additional_flags=-gnat12}] != ""} {
>> return -1
>> }
>>
Committed.