This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR symtab/17890] punt if dwarf line header version > 4
- From: Doug Evans <dje at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Cary Coutant <ccoutant at google dot com>
- Date: Thu, 29 Jan 2015 10:35:30 -0800
- Subject: Re: [PATCH] [PR symtab/17890] punt if dwarf line header version > 4
- Authentication-results: sourceware.org; auth=none
- References: <yjt2r3uek4fi dot fsf at ruffy dot mtv dot corp dot google dot com> <20150129044312 dot GA5193 at adacore dot com>
On Wed, Jan 28, 2015 at 8:43 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I opted to be conservative and not break something if a user
>> just happened to be using a broken toolchain that emits
>> version 0 or 1 but is still usable by gdb.
>> I'm more than happy to be more strict though!
>
> FWIW, I think it's a valid concern. We can always revisit later
> if we happen to see something that requires us to be stricter.
>
>> 2015-01-28 Doug Evans <dje@google.com>
>>
>> PR symtab/17890
>> * dwarf2read.c (dwarf_decode_line_header): Punt if version > 4.
>
> LGTM.
Thanks, committed to trunk and gdb-7.9-branch.