This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv3] Fix 100x slowdown regression on DWZ files
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 23 Jan 2015 17:46:45 -0800
- Subject: Re: [patchv3] Fix 100x slowdown regression on DWZ files
- Authentication-results: sourceware.org; auth=none
- References: <CADPb22Q2r9Vnne5rDapAy=AuD2AKBU01TRANw3djo5Xk1icvNw at mail dot gmail dot com> <21548 dot 37770 dot 274873 dot 760290 at ruffy2 dot mtv dot corp dot google dot com> <20141002155653 dot GA9001 at host2 dot jankratochvil dot net> <20141231192335 dot GA8188 at host2 dot jankratochvil dot net> <21677 dot 57646 dot 178793 dot 836948 at ruffy2 dot mtv dot corp dot google dot com> <20150114202618 dot GA21056 at host2 dot jankratochvil dot net> <21697 dot 17716 dot 292890 dot 813248 at ruffy2 dot mtv dot corp dot google dot com> <20150122185509 dot GA16253 at host2 dot jankratochvil dot net>
On Thu, Jan 22, 2015 at 10:55 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Thu, 22 Jan 2015 19:45:08 +0100, Doug Evans wrote:
>> In my mind it's easier to just treat a non-NULL value for line_header_hash
>> as the flag to decide whether we're using the hash (instead of
>> seen_partial_unit).
>
> Yes, sure I agree. I just haven't realized this simplificaton while coding it.
>
>
>> Sound ok?
>
> Yes, I am fine with your change; so I expect you can check it in when you ask
> this way.
Can you check it in? Thanks.