Re: [PATCH] PR 17520 -- structure offset wrong when 1/4 GB or greater

[Joel Brobecker <brobecker at adacore dot com>]

> > Can you add a copyright header to that file, please? All files should
> > have a copyright header unless there is a compelling reason whe cannot
> > add it.
> 
> Done.
> 
> The file is short enough that I'm not sure that it really is
> copyrightable -- but, the lawyers can argue that one, I don't care.

Indeed, some files might be small enough as to not be legally
significant in terms of copyright issues. But rather than introduce
a human decision into the mix, it's just easier to add copyright
headers everywhere. And we have the script which updates all copyright
notices everywhere at the start of the year which tells us if new files
have been introduced without a copyright header.

> I noticed that most of the testsuite *.c files, at least in gdb.base
> do not have copyright notices.

That is a mistake that we should be correcting, but it usually takes
someone seeing the error, then digging through history to figure out
the copyright range, and then adding it.

> I found an example that did something similar to what I wanted and
> copied it.  It had the timeout within the gdb_test_multiple, so that is
> what I did, too.

For TCL, I do the same, but unfortunately, there is a lot of old
baggage, as you've discovered. We try to fix this too, as we see it,
but it's a nearly endless source of work, so progress is usually, er,
slow (understatement).

In case you haven't seen it yet, there is a cookbook:
http://sourceware.org/gdb/wiki/GDBTestcaseCookbook

If some recipes are missing, we'd be glad to add to it.

> I try to do as little as possible in Tcl as every time I do anything
> significant, by the time I'm done I'm remembering just how much I hate
> writing Tcl code.

+1.

-- 
Joel