This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V5 2/3] Add AVX512 register support to gdbserver.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: "Sturm, Michael" <michael dot sturm at intel dot com>
- Cc: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, "palves at redhat dot com" <palves at redhat dot com>, "eliz at gnu dot org" <eliz at gnu dot org>, "mark dot kettenis at xs4all dot nl" <mark dot kettenis at xs4all dot nl>, "Tedeschi, Walfred" <walfred dot tedeschi at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 10 Jan 2015 11:00:35 +0400
- Subject: Re: [PATCH V5 2/3] Add AVX512 register support to gdbserver.
- Authentication-results: sourceware.org; auth=none
- References: <1398258160-9070-1-git-send-email-michael dot sturm at intel dot com> <1398258160-9070-3-git-send-email-michael dot sturm at intel dot com> <87ppcgrh0o dot fsf at br87z6lw dot de dot ibm dot com> <20141213134146 dot GE5457 at adacore dot com> <DB865139DDA33A4DA36CC4A460C1127331C0851E at irsmsx105 dot ger dot corp dot intel dot com>
Hello,
> Sorry for the late reply! Yes, the proposed change is correct. Thanks
> a lot for catching this bug!
Thanks for confirming.
Attached is the patch I ended up pushing.
gdb/gdbserver/ChangeLog:
* i387-fp.c (i387_cache_to_xsave): In look over
num_avx512_zmmh_high_registers, replace use of struct i387_xsave
zmmh_low_space field by use of zmmh_high_space.
Tested on x86_64-linux, using boards/native-gdbserver.exp.
--
Joel
>From 3368c1e5ce12ea262ab3ff7a9154472503aadedb Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Sat, 10 Jan 2015 09:50:44 +0400
Subject: [PATCH] Fix use of wrong struct i387_xsave field in
i387_cache_to_xsave
gdb/gdbserver/ChangeLog:
* i387-fp.c (i387_cache_to_xsave): In look over
num_avx512_zmmh_high_registers, replace use of struct i387_xsave
zmmh_low_space field by use of zmmh_high_space.
Tested on x86_64-linux, using boards/native-gdbserver.exp.
---
gdb/gdbserver/ChangeLog | 6 ++++++
gdb/gdbserver/i387-fp.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 180e341..d126748 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2015-01-10 Joel Brobecker <brobecker@adacore.com>
+
+ * i387-fp.c (i387_cache_to_xsave): In look over
+ num_avx512_zmmh_high_registers, replace use of struct i387_xsave
+ zmmh_low_space field by use of zmmh_high_space.
+
2015-01-09 Pedro Alves <palves@redhat.com>
* linux-low.c (step_over_bkpt): Move higher up in the file.
diff --git a/gdb/gdbserver/i387-fp.c b/gdb/gdbserver/i387-fp.c
index a4c218d..ddfec6e 100644
--- a/gdb/gdbserver/i387-fp.c
+++ b/gdb/gdbserver/i387-fp.c
@@ -454,7 +454,7 @@ i387_cache_to_xsave (struct regcache *regcache, void *buf)
for (i = 0; i < num_avx512_zmmh_high_registers; i++)
{
collect_register (regcache, i + zmm16h_regnum, raw);
- p = ((char *) &fp->zmmh_low_space[0]) + 32 + i * 64;
+ p = ((char *) &fp->zmmh_high_space[0]) + 32 + i * 64;
if (memcmp (raw, p, 32) != 0)
{
xstate_bv |= X86_XSTATE_ZMM;
--
1.9.1