This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ping^2: [patchv2] Fix 100x slowdown regression on DWZ files
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 8 Jan 2015 16:32:27 -0800
- Subject: Re: ping^2: [patchv2] Fix 100x slowdown regression on DWZ files
- Authentication-results: sourceware.org; auth=none
- References: <CADPb22Q2r9Vnne5rDapAy=AuD2AKBU01TRANw3djo5Xk1icvNw at mail dot gmail dot com> <21548 dot 37770 dot 274873 dot 760290 at ruffy2 dot mtv dot corp dot google dot com> <20141002155653 dot GA9001 at host2 dot jankratochvil dot net> <20141231192335 dot GA8188 at host2 dot jankratochvil dot net> <21677 dot 57646 dot 178793 dot 836948 at ruffy2 dot mtv dot corp dot google dot com>
Doug Evans writes:
> Do hashtables support calling htab_find_slot with INSERT but then
> not assigning the slot a value if it was empty?
> I could be wrong but I think it does.
> If so, we can remove one call to htab_find_slot here.
I was wrong.
I thought I was, but I couldn't remember, and couldn't remember where
I had seen this. But htab_find_slot_with_hash does assume
that if you call it with INSERT, and the slot isn't already used,
then you're going to fill in the slot.
No matter, it was just a thought.