This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Remove superfluous function key_is_command_char()
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 08 Jan 2015 16:58:43 +0200
- Subject: Re: [PATCH 1/3] Remove superfluous function key_is_command_char()
- Authentication-results: sourceware.org; auth=none
- References: <1420689885-31156-1-git-send-email-patrick at parcs dot ath dot cx> <83zj9t5rbe dot fsf at gnu dot org> <CA+C-WL_F-VD2Z0mY2WEjW1zGayz9aw0CYFZGuWRfr6c5+ww_yQ at mail dot gmail dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Patrick Palka <patrick@parcs.ath.cx>
> Date: Thu, 8 Jan 2015 08:47:44 -0500
> Cc: gdb-patches@sourceware.org
>
> > But tui_dispatch_ctrl_char punts when the current window is the
> > command window, doesn't it? This means we are losing the possibility
> > to handle command keys in the command window.
>
> I don't see how that follows. If the current window is the command
> window then dispatch_ctrl_char() returns the input character
> unmodified. So the behavior after the patch is the same as if the
> call to dispatch_ctrl_char() was guarded by the key_is_command_char()
> predicate, before the patch.
Sorry, you are right.