This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Remove superfluous function key_is_command_char()
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: gdb-patches at sourceware dot org, patrick at parcs dot ath dot cx
- Date: Thu, 08 Jan 2015 15:34:45 +0200
- Subject: Re: [PATCH 1/3] Remove superfluous function key_is_command_char()
- Authentication-results: sourceware.org; auth=none
- References: <1420689885-31156-1-git-send-email-patrick at parcs dot ath dot cx>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Patrick Palka <patrick@parcs.ath.cx>
> Cc: Patrick Palka <patrick@parcs.ath.cx>
> Date: Wed, 7 Jan 2015 23:04:43 -0500
>
> The function key_is_command_char() is simply a predicate that determines
> whether the function tui_dispatch_ctrl_char() will do anything useful.
> Since tui_dispatch_ctrl_char() performs the same checks as
> key_is_command_char() it is unnecessary to keep key_is_command_char()
> around. This patch removes this useless function and instead
> unconditionally calls tui_dispatch_ctrl_char() inside its only caller,
> tui_getc().
But tui_dispatch_ctrl_char punts when the current window is the
command window, doesn't it? This means we are losing the possibility
to handle command keys in the command window.
Thanks.