This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/8] linux-nat.c: better starvation avoidance, handle non-stop mode too


On 01/07/2015 02:08 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> That is, the LWP had previously stopped for a breakpoint, and we
>> left that event pending.  But if the breakpoint is now gone,
>> GDB core isn't interested in it anymore, so we just discard
>> that event.
> 
> The breakpoint is gone because it is removed by user, for example,
> it that correct?

Yeah, removed for any reason, really.  Another example would be because it
was a step-resume breakpoint for another thread and that other thread
no longer needs it, so GDB meanwhile removed it.

> 
>> Here's the updated patch.
> 
> It looks good to me.

Thank you for the review.

Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]