This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHSET] [2/4] Fix various issue in TUI
- From: Pedro Alves <palves at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Mon, 05 Jan 2015 19:11:21 +0000
- Subject: Re: [PATCHSET] [2/4] Fix various issue in TUI
- Authentication-results: sourceware.org; auth=none
- References: <83y4pnbtnc dot fsf at gnu dot org>
On 12/31/2014 05:45 PM, Eli Zaretskii wrote:
> This patch fixes the problem whereby setting the border attributes had
> no effect whatsoever.
Rather, you need to switch out of the TUI and back, with c-x,a.
> Turns out no one was calling the functions that
> detected changes in these settings and applied them to windows.
Thanks.
> While at that, this also fixes a copy/paste error in a comment to a
> function.
Could you please push this part separately?
>
> OK?
>
> 2014-12-31 Eli Zaretskii <eliz@gnu.org>
>
> * tui/tui-win.c (tui_rehighlight_all): New function.
>
No empty lines between ChangeLog entries, please.
> * tui/tui-win.h: Add prototype for tui_rehighlight_all.
>
> * tui/tui-command.c (tui_dispatch_ctrl_char): When Ctrl-L was
> pressed, call tui_rehighlight_all if tui_update_variables
> indicates it should be.
tabs vs spaces.
>
> * tui/tui-win.c (tui_refresh_all_command): Call
> tui_rehighlight_all if tui_update_variables indicates it
> should be.
>
> * tui/tui-hooks.c (tui_note_setting_change): New function.
> (tui_install_hooks): Install an observer for "command
> parameter changed".
> (tui_remove_hooks): Uninstall the observer.
>
>
> --- gdb/tui/tui-win.h~0 2014-06-11 18:34:41 +0300
> +++ gdb/tui/tui-win.h 2014-12-31 13:38:18 +0200
> @@ -35,6 +35,7 @@
> extern void tui_set_win_focus_to (struct tui_win_info *);
> extern void tui_resize_all (void);
> extern void tui_refresh_all_win (void);
> +extern void tui_rehighlight_all (void);
>
> extern chtype tui_border_ulcorner;
> extern chtype tui_border_urcorner;
>
>
> --- gdb/tui/tui-command.c~0 2014-10-29 21:45:50 +0200
> +++ gdb/tui/tui-command.c 2014-12-31 13:49:43 +0200
> @@ -50,7 +50,12 @@
Seems like you're not using git diff to generate the diffs
for some reason. If using GNU diff, could you make sure
to use the "-p" switch? It makes review a lot easier.
>
> --- gdb/tui/tui-command.c~0 2014-10-29 21:45:50 +0200
> +++ gdb/tui/tui-command.c 2014-12-31 13:49:43 +0200
> @@ -50,7 +50,12 @@
>
> /* Handle the CTRL-L refresh for each window. */
> if (ch == '\f')
> - tui_refresh_all_win ();
> + {
> + if (tui_update_variables ())
> + tui_rehighlight_all ();
> +
> + tui_refresh_all_win ();
tui_refresh_all_win already calls tui_check_and_display_highlight_if_needed,
so why do we need to call tui_rehighlight_all? Is it the tui_update_variables
call that is really missing? But why would we need to call
tui_update_variables on CTRL-L, if we already call it when the user
changes the variables?
> + }
>
> /* If the command window has the logical focus, or no-one does
> assume it is the command window; in this case, pass the character
>
>
> --- gdb/tui/tui-hooks.c~0 2014-06-11 18:34:41 +0300
> +++ gdb/tui/tui-hooks.c 2014-12-31 14:41:11 +0200
> @@ -247,12 +247,23 @@
> tui_display_main ();
> }
>
> +/* Refresh the display when settings important to us change. */
> +static void
> +tui_note_setting_change (const char *param, const char *value)
> +{
> + if (tui_active
> + && strncmp (param, "tui ", sizeof ("tui ") - 1) == 0
> + && tui_update_variables ())
> + tui_rehighlight_all ();
> +}
> +
Please do this from the "set" hook of the relevant commands instead.
IOW, replace NULL below (and in the other commands):
add_setshow_enum_cmd ("active-border-mode", no_class, tui_border_mode_enums,
&tui_active_border_mode, _("\
...
NULL,
show_tui_active_border_mode,
&tui_setlist, &tui_showlist);
> @@ -985,11 +995,14 @@
> /* Make sure the curses mode is enabled. */
> tui_enable ();
>
> + if (tui_update_variables ())
> + tui_rehighlight_all ();
> +
> tui_refresh_all_win ();
> }
>
I don't understand this one. When is it ever necessary?
Thanks,
Pedro Alves