This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build]
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: palves at redhat dot com, ktietz at redhat dot com, sellcey at imgtec dot com, brobecker at adacore dot com, yao at codesourcery dot com, gdb-patches at sourceware dot org
- Date: Fri, 19 Dec 2014 10:23:59 +0200
- Subject: Re: [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build]
- Authentication-results: sourceware.org; auth=none
- References: <20141217210144 dot GA26674 at host2 dot jankratochvil dot net> <549206B1 dot 40902 at redhat dot com> <20141218181432 dot GA19996 at host2 dot jankratochvil dot net> <54931BBB dot 3080304 at redhat dot com> <20141218184123 dot GA20422 at host2 dot jankratochvil dot net> <549325FB dot 9040705 at redhat dot com> <20141218210445 dot GA23134 at host2 dot jankratochvil dot net> <83h9wsu0i3 dot fsf at gnu dot org> <20141218212353 dot GA23599 at host2 dot jankratochvil dot net>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Thu, 18 Dec 2014 22:23:53 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: palves@redhat.com, ktietz@redhat.com, sellcey@imgtec.com,
> brobecker@adacore.com, yao@codesourcery.com,
> gdb-patches@sourceware.org
>
> On Thu, 18 Dec 2014 22:11:16 +0100, Eli Zaretskii wrote:
> > If this is a problem, how about writing down the requirements?
>
> I was more general above.
So was I. If you think our requirements are not detailed enough, with
the result of complicating the patch submission process and the job of
contributors, I think we should try to put more details into the
existing documentation.
Of course, some requirements that come up during the review cannot
possibly be codified, because they are general principles or minor
preferences that are too many to write down. I don't think we can
avoid that, but we could try. E.g., after each such issue comes up,
we could ask ourselves whether it is worth adding to the
documentation.