This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/5] libthread_db: debug output should go to gdb_stdlog
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 17 Dec 2014 22:08:39 +0800
- Subject: Re: [PATCH 1/5] libthread_db: debug output should go to gdb_stdlog
- Authentication-results: sourceware.org; auth=none
- References: <1418748834-27545-1-git-send-email-palves at redhat dot com> <1418748834-27545-2-git-send-email-palves at redhat dot com> <871tnyu2k7 dot fsf at codesourcery dot com> <549188E2 dot 5000907 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> Let me answer that by adding a comment. Does this make it clearer?
Yes, it is clearer....
>
> if (*libthread_db_search_path || libthread_db_debug)
... and it is also important to exchange them in the condition.
> {
> struct ui_file *file;
> const char *library;
>
> library = dladdr_to_soname (*info->td_ta_new_p);
> if (library == NULL)
> library = LIBTHREAD_DB_SO;
>
> /* If we'd print this to gdb_stdout when debug output is
> disabled, still print it to gdb_stdout if debug output is
> enabled. User visible output should not depend on debug
> settings. */
--
Yao (éå)